-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Outlook] (spam reporting) Add support for the unified manifest for Microsoft 365 #940
base: main
Are you sure you want to change the base?
[Outlook] (spam reporting) Add support for the unified manifest for Microsoft 365 #940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change and some questions.
|
||
1. Follow the steps in [Try it out](#try-it-out) to test the sample. | ||
|
||
> **Note**: You can't debug a spam-reporting add-in that uses the unified manifest at this time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for my personal curiosity, why would this be? The JavaScript that's being debugged is the same, isn't it? Why would the type of manifest matter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into this further and you're right; we should be able to debug since the bundle.js file of an add-in that uses the unified manifest is still added to the Wef folder. I'll correct the signature sample as well.
What's in this Pull Request?
Adds support for the unified manifest for Microsoft 365 to the spam-reporting sample.